Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporal Controller ends with a Frame with Step size == zero #40777

Closed
rduivenvoorde opened this issue Dec 28, 2020 · 0 comments · Fixed by #43660
Closed

Temporal Controller ends with a Frame with Step size == zero #40777

rduivenvoorde opened this issue Dec 28, 2020 · 0 comments · Fixed by #43660
Assignees
@nyalldawson
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Temporal Temporal filtering or animation

Comments

@rduivenvoorde
Copy link
Contributor

The last frame in the (visual) Temporal Controller ends with a 'Frame' of size zero:

Screenshot-20201228130853-788x150

As you see, my (hourly test) data goes from 01:00 till 07:00 (max end time).
If you load such data in QGIS the range is filled (rightly) with the Range you see in the screenshot.
But if you step through the Frames (with given stepsize = 1 hour), the LAST step will be the one you see in the screenshot: going from 07:00 to 07:00.
I think that is wrong. I think that (IF you want to show that frame) it should be last timeframe+stepsize (so in this case 07:00 to 08:00).
Now having a testset with both csv and geopackage, the both data providers seem to work differently with such Frame.
(I think I can have a look into this myself, later. But if somebody does NOT agree, or knows if this is deliberatly, please let me know.
@rduivenvoorde rduivenvoorde added Bug Either a bug report, or a bug fix. Let's hope for the latter! Temporal Temporal filtering or animation labels Dec 28, 2020
@rduivenvoorde rduivenvoorde mentioned this issue Dec 29, 2020
Closed
@rduivenvoorde rduivenvoorde mentioned this issue Jun 9, 2021
Merged
@nyalldawson nyalldawson self-assigned this Jun 10, 2021
nyalldawson added a commit to nyalldawson/QGIS that referenced this issue Jun 10, 2021
@nyalldawson
[temporal] Fix incorrect frame duration in last frame in animation mode
0221122 
The final frame must always have the same duration as other frames,
even if this means we go past the end of the animation range. Also
avoid showing a "zero length" frame at the end of the animation
if the frame duration fits exactly into the overall animation
range.

Fixes qgis#40777
@nyalldawson nyalldawson mentioned this issue Jun 10, 2021
Merged
nyalldawson added a commit that referenced this issue Jun 14, 2021
@nyalldawson
[temporal] Fix incorrect frame duration in last frame in animation mode
f76747b 
The final frame must always have the same duration as other frames,
even if this means we go past the end of the animation range. Also
avoid showing a "zero length" frame at the end of the animation
if the frame duration fits exactly into the overall animation
range.

Fixes #40777
nyalldawson added a commit to nyalldawson/QGIS that referenced this issue Jun 14, 2021
@nyalldawson
[temporal] Fix incorrect frame duration in last frame in animation mode
60ebb7f 
The final frame must always have the same duration as other frames,
even if this means we go past the end of the animation range. Also
avoid showing a "zero length" frame at the end of the animation
if the frame duration fits exactly into the overall animation
range.

Fixes qgis#40777

(cherry picked from commit 0221122)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nyalldawson nyalldawson

Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Temporal Temporal filtering or animation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect frame duration in last frame in animation mode nyalldawson/QGIS
Temporal gui fixes
2 participants
@rduivenvoorde @nyalldawson