Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional QgsProcessingParameterExpression defaults to field if input has one field #41063

Closed
uclaros opened this issue Jan 18, 2021 · 1 comment · Fixed by #41089
Closed

Optional QgsProcessingParameterExpression defaults to field if input has one field #41063

uclaros opened this issue Jan 18, 2021 · 1 comment · Fixed by #41089
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms

Comments

@uclaros
Copy link
Contributor

uclaros commented Jan 18, 2021

Describe the bug

A processing algorithm that uses an optional QgsProcessingParameterExpression defaults its value to input field if the input layer has one field only, instead of being left blank like when there are more fields or no fields.

How to Reproduce
Open a point layer that has a single field and load the c++ points to path algorithm. Both order expression and group expression defaults to the single field instead of being blank.

QGIS and OS versions
Master on debian testing
@uclaros uclaros added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Jan 18, 2021
@nyalldawson
Copy link
Collaborator

Possibly a matter of just setting QgsFieldExpressionWidget::setAllowEmptyFieldName(true) in QgsProcessingExpressionWidgetWrapper::createWidget() for optional expressions

@gioman gioman added the Processing Relating to QGIS Processing framework or individual Processing algorithms label Jan 19, 2021
nyalldawson added a commit to nyalldawson/QGIS that referenced this issue Jan 19, 2021
@nyalldawson
[processing] Don't default to input field for optional expression par…
0374623 
…ameters

Fixes qgis#41063
@nyalldawson nyalldawson mentioned this issue Jan 19, 2021
Merged
nyalldawson added a commit that referenced this issue Jan 20, 2021
@nyalldawson
[processing] Don't default to input field for optional expression par…
1fed902 
…ameters

Fixes #41063
nyalldawson added a commit to nyalldawson/QGIS that referenced this issue Jan 20, 2021
@nyalldawson
[processing] Don't default to input field for optional expression par…
544e621 
…ameters

Fixes qgis#41063

(cherry picked from commit 1fed902)
@nyalldawson nyalldawson mentioned this issue Jan 20, 2021
Closed
nyalldawson added a commit to nyalldawson/QGIS that referenced this issue Feb 19, 2021
@nyalldawson
[processing] Don't default to input field for optional expression par…
91236c5 
…ameters

Fixes qgis#41063

(cherry picked from commit 1fed902)
nyalldawson added a commit that referenced this issue Feb 19, 2021
@nyalldawson
[processing] Don't default to input field for optional expression par…
6c095d2 
…ameters

Fixes #41063

(cherry picked from commit 1fed902)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[processing] Don't default to input field for optional expression parameters nyalldawson/QGIS
3 participants
@nyalldawson @gioman @uclaros