"Ignore invalid input features" processing setting location is misleading

[esnyder-rve]

Describe the bug
This is not really a bug, but not really a feature request either. It's more or less a quality of life improvement.

I was trying to clip FEMA flood areas to an area of interest, and there's self-intersecting polygons causing native:clip to fail with CRITICAL Feature (343) from “FEMA Flood Zones” has invalid geometry. Please fix the geometry or change the Processing setting to the “Ignore invalid input features” option. Since I cannot change the dataset, I would need to ignore invalid features. At first, it seams like this option would be a parameter that I just looked over since it's called an "option", but it's found it in the global QGIS Processing settings. In English, there is no setting or setting option of "Ignore invalid input features", but rather the setting is "Invalid features filtering" with the options of "Do not filter (better performance)", "Skip (ignore) features with invalid geometries", and "Stop algorithm execution when a geometry is invalid"; with the last option being the default.

I'm fine with keeping the default, but it would be nice to see a more helpful error message presented to the user. Maybe something like this: CRITICAL Feature (343) from “FEMA Flood Zones” has invalid geometry. Please fix the geometry or change the "Invalid features filtering" setting found in Settings -> Options -> Processing -> General.

Or something along those lines to more easily guide the user to where this setting is. Not sure if a link can be put there to launch that window similarly to the "You can add more algorithms to the toolbox, enable additional providers."

[DelazJ]

@esnyder-rve If you want to give it a try, here's afaict the place where the sentence(s) need to be fixed
https://github.com/qgis/QGIS/blob/master/src/core/processing/qgsprocessingcontext.cpp#L86

[roya0045]

I recall that his option was also exposed in the algorithm dialog, or some of them.

[agiudiceandrea]

@roya0045 it is an Advanced option available in the processing tools that use vector layer as input

[roya0045]

@agiudiceandrea Yes this is what I had in mind, the version I had on hand was too old to have that, so I couldn't' validate if it was only for the feature input or on layer input too. Thanks for the screenshot.

[esnyder-rve]

@agiudiceandrea I never knew that was there. So, how about this:

CRITICAL Feature (n) from layer “fooBar” has invalid geometry. Please fix the geometry or change the "Invalid feature filtering" advanced option for this input layer (the wrench icon in processing parameters), or the global setting found in Settings -> Options -> Processing -> General.

Is this too verbose? I would like the error message to be helpful, but not overwhelming.

[rduivenvoorde]

I think it is OK to be verbose... it is in the verbose outputs anyway.

One related remark: even IF you enable this setting to ignore it, the message still pops up in red in the log:

Arrgh!! No No it IS good: it says that that setting IS set...