Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFS connection manager: GetCapabilities document's URLs not being used consistently #45242

Closed
2 tasks done
kit-rothwell opened this issue Sep 24, 2021 · 5 comments
Closed
2 tasks done
Assignees
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! WFS data provider

Comments

@kit-rothwell
Copy link

What is the bug or the crash?

If you are using a GetCapabilities endpoint that proxies to GeoServer, and you add a layer with the WFS connection manager the majority of URLs (GetFeature, DescribeFeatureType, etc) are using the URLs in the document as expected. But if you open the attribute table and try to edit some data, it will try to use the proxy URL to make the post request.

Additionally if you double click a layer in the WFS connection manager it will make a DescribeFeatureType request and attempt to use the proxy URL for that as well.

I have used the 'QGIS Network Logger' plugin to observe the requests being made:
image
You can see in the request list it's generally calling the raw geoserver endpoint which is as expected, except when it attempts to make the post request and then tries to use the URL entered for the connection.

Steps to reproduce the issue

Post request issue:

  1. Go to 'Layer' > 'Add Layer' > 'Add WFS Layer'
  2. Click on 'New' under Server Connections
  3. Enter a name and the proxy URL used to get the capabilities document in connection details, then click 'OK'
  4. Click on 'Connect' under Server Connections and add the layer that appears in the list
  5. Go to the Layers panel and right click on the layer that was added then click 'Open Attribute Table'
  6. Click on 'Toggle editing mode' button, and then update the data in a cell and attempt to save
  7. Observe the commit error that appears at the top of the viewer panel

DescribeFeatureType issue:

  1. Go to 'Layer' > 'Add Layer' > 'Add WFS Layer'
  2. Click on 'New' under Server Connections
  3. Enter a name and the proxy URL used to get the capabilities document in connection details, then click OK
  4. Click on 'Connect' under Server Connections and double click the layer that appears in the list
  5. Observe the Server exception error dialogue that appears

Versions

3.20.3-Odense

Supported QGIS version

  • I'm running a supported QGIS version according to the roadmap.

New profile

  • I tried with a new QGIS profile

Additional context

Also tried this on 3.12.3 before updating to 3.20.3 to see if the issue was present in the later version.

@kit-rothwell kit-rothwell added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Sep 24, 2021
@rouault
Copy link
Contributor

rouault commented Sep 25, 2021

Could you provide a URL to a server that demonstrates the issue ?

@gioman gioman added the Feedback Waiting on the submitter for answers label Sep 25, 2021
@kit-rothwell
Copy link
Author

kit-rothwell commented Sep 27, 2021

Could you provide a URL to a server that demonstrates the issue ?

@rouault I can provide one privately, do you have an email I could send it to?

@rouault
Copy link
Contributor

rouault commented Sep 27, 2021

I can provide one privately, do you have an email I could send it to?

even.rouault at spatialys.com

@kit-rothwell
Copy link
Author

Thanks, I've sent an email

@rouault rouault self-assigned this Sep 27, 2021
@rouault rouault removed the Feedback Waiting on the submitter for answers label Sep 27, 2021
@rouault
Copy link
Contributor

rouault commented Sep 27, 2021

#45267 fixes the 2 issues with the test server provided privately

rouault added a commit that referenced this issue Sep 27, 2021
[WFS provider] Honour DCP HTTP URLs for transactions and SQL query builder (fixes #45242)
espinafre pushed a commit to espinafre/QGIS that referenced this issue Sep 29, 2021
elpaso added a commit that referenced this issue Oct 1, 2021
…ports

[Backport queued_ltr_backports] [WFS provider] Honour DCP HTTP URLs for transactions and SQL query builder (fixes #45242)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! WFS data provider
Projects
None yet
Development

No branches or pull requests

3 participants