Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Save all Styles/Save current Style' only appears after close/reopen the layer properties window #46596

Closed
DelazJ opened this issue Dec 22, 2021 · 3 comments · Fixed by #47080
Closed

'Save all Styles/Save current Style' only appears after close/reopen the layer properties window #46596

DelazJ opened this issue Dec 22, 2021 · 3 comments · Fixed by #47080
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! GUI/UX Related to QGIS application GUI or User Experience

Comments

@DelazJ
Copy link
Contributor

DelazJ commented Dec 22, 2021

I was writing documentation for this new feature and I noticed that the options ‚Save all Styles‘/‘Save current Style‘ only appears on my system after close/reopen the layer properties window (see pictures). I don't know if this really matters, but wanted to tell you anyway.
Greetings,
Jörn
Style_Menu_1
Style_Menu_2
Bildschirmfoto von 2021-12-16 11-46-01

Originally posted by @Gutzeit555 in qgis/QGIS-Documentation#4398 (comment)
@DelazJ DelazJ mentioned this issue Dec 22, 2021
Closed
2 tasks
@DelazJ DelazJ added Bug Either a bug report, or a bug fix. Let's hope for the latter! GUI/UX Related to QGIS application GUI or User Experience labels Dec 22, 2021
@Djedouas
Copy link
Member

You have to close/reopen the window only if you create a new style in that window.

If, before opening the properties window, you add a style with a right click on the layer -> Styles -> Add... then when you open the properties, the layer already have more than one style, and the "Save all styles" option is available.

@DelazJ
Copy link
Contributor Author

DelazJ commented Dec 23, 2021

You have to close/reopen the window only if you create a new style in that window.

IMO that is the issue. You shouldn't have to close/reopen the whole window. A signal should be sent to update that widget the next time you open it.

@Djedouas
Copy link
Member

IMO that is the issue.

Right I agree, I wanted to be sure about your tests 😉

@SebastienPeillet SebastienPeillet mentioned this issue Dec 23, 2021
Closed
nyalldawson added a commit to nyalldawson/QGIS that referenced this issue Jan 31, 2022
@nyalldawson
Build vector layer style menu add display time, so that it can
a5b7f76 
correctly respond to creation/removal of styles within the layer
properties dialog

Fixes qgis#46596
@nyalldawson nyalldawson mentioned this issue Jan 31, 2022
Merged
nyalldawson added a commit that referenced this issue Feb 1, 2022
@nyalldawson
Build vector layer style menu add display time, so that it can
2481b1b 
correctly respond to creation/removal of styles within the layer
properties dialog

Fixes #46596
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! GUI/UX Related to QGIS application GUI or User Experience
Projects
None yet
Milestone
No milestone
2 participants
@DelazJ @Djedouas