Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Allow edit form code" message box misleading #46974

Open
2 tasks done
m-kuhn opened this issue Jan 24, 2022 · 3 comments
Open
2 tasks done

"Allow edit form code" message box misleading #46974

m-kuhn opened this issue Jan 24, 2022 · 3 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! GUI/UX Related to QGIS application GUI or User Experience

Comments

@m-kuhn
Copy link
Member

m-kuhn commented Jan 24, 2022

What is the bug or the crash?

The "allow edit form code" message box is currently misleading in one aspect and could better guide the user to protect from executing code.

image

  1. The "Don't Ask Anymore" is not clear what the implications are. I.e. is it "Allow and do not ask again" or "Forbid and do not ask again". From reading the code it's the second (disallow for the current session), it should be explicit about this.
  2. The "protect" concern is a bit more hidden. Currently, for a user to run the code two options are available, click "Yes" or enable macros globally. Since continuously clicking yes quickly becomes tedious the path of least resistance is globally enabling macros which is a security risk (which is the whole reason for this dialog to exist). Better would be if specific projects could be flagged as trusted -- or even complete folders being flagged as trusted folders. For comparison an equivalent dialog from vs code

image

Steps to reproduce the issue

  1. Open project with form init code
  2. Open form

Versions

3.16 / master

Supported QGIS version

  • I'm running a supported QGIS version according to the roadmap.

New profile

  • I tried with a new QGIS profile

Additional context

No response

@m-kuhn m-kuhn added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Jan 24, 2022
@m-kuhn
Copy link
Member Author

m-kuhn commented Jan 24, 2022

@elpaso keen to hear your thoughts

m-kuhn added a commit to m-kuhn/QGIS that referenced this issue Jan 24, 2022
@gioman gioman added the GUI/UX Related to QGIS application GUI or User Experience label Jan 24, 2022
@m-kuhn
Copy link
Member Author

m-kuhn commented Jan 24, 2022

Part 1 cosmetically fixed, backport pending.

qgis-bot pushed a commit that referenced this issue Jan 24, 2022
nyalldawson pushed a commit that referenced this issue Jan 25, 2022
@alexbruy
Copy link
Contributor

Related issue #32525

nyalldawson pushed a commit that referenced this issue Feb 20, 2022
nyalldawson pushed a commit that referenced this issue Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! GUI/UX Related to QGIS application GUI or User Experience
Projects
None yet
Development

No branches or pull requests

3 participants