-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unreadable text in dark theme #47065
Comments
Maybe we could take something like this and use some well worked out themes to deal with darkness... |
@timlinux , I'd use night mapping theme as a starting point. It's now pretty solid and has QGIS specific rules. It'd then be a matter of changing the color variable definition and some css properties to match desired outcome. |
@nirvn I'm a little confused why we have src/app/qgisappstylesheet.cpp, since by the look of that logic we need to override not only the stylesheets but change theme specific code. Would you suggest adding another if clause in appstylesheet.cpp to provide dark theme defaults. Also confusing to me is that my QGIS3.ini is still set to default since the darkness hint comes from my gnome theme rather than an explicit choice to use night mapping - so I am not even sure if I am using night mapping or dedault at run time (guess I will go and poke around in the pythin console to check on that). [UI]
UITheme=default
allWidgetsVisible=false
annotationTool=3
|
Are you on Linux or OSX? |
Linux @nirvn |
@timlinux , and what's your Qt style? Fusion? I didn't know that had dark theme awareness. In any case, you're definitely not on a non default theme. I suspect you're using a Qt style that's badly emulating gnome adwaita's dark mode or something. You can switch to the night mapping theme, that'll hardcode Qt style to fusion. |
hi @nirvn yes it is already on fusion and the UI theme at the moment is default. I can switch to Night Mapping (see below) but I think that kinda bypasses the problem: When users have a dark theme active on their desktop parts of QGIS are unreadable / very poorly readable. When I switch to night mapping, it does indeed provide readable labels in the list widget. I wonder if we could somehow detect that a user is in dark mode and enable dark mapping? Though I guess that will break other cases where they have a custom Qt theme active.... |
Right. I think we need a generic approach to handle this, as I also get frustrated with "invisible" white symbols in the list on light themes! |
Breaks readability on dark themes Refs qgis#47065
This breaks dark theme readability Fixes qgis#47065
Breaks readability on dark themes Refs #47065
This breaks dark theme readability Fixes #47065
Breaks readability on dark themes Refs #47065
This breaks dark theme readability Fixes #47065
Breaks readability on dark themes Refs #47065
This breaks dark theme readability Fixes #47065
Thanks for the fixes @nyalldawson, I am reopening because I found another one! (referring to the buttons above). |
unreadable text on dark themes Fixes qgis#47065
unreadable text on dark themes Fixes qgis#47065
unreadable text on dark themes Fixes #47065
This breaks dark theme readability Fixes #47065
Breaks readability on dark themes Refs #47065
This breaks dark theme readability Fixes #47065
Ditto, drop downs went dark for me from 3.22.10 to 3.22.12 |
The night mapping dark menu text has been fixed, will be available in the next point release. |
Ditto, I can confirm regression on 3.22.12. |
Ditto, menu text has been dark and unreadable for me on 3.22.12 and 3.28.0 |
I had never had any issue with night mapping on other versions of QGIS (using since 3.14, I think), and after updating from 3.26 to 3.28 last week, now I have this issue: I'm on Win10 with dark mode, but it had never been an issue so far, everything always readable. I've tried restarting QGIS and even changing the style and ui theme and doesn't solve it. |
@nirvn Should this issue be closed ? |
Does it also fix the widget rendering, as described here #47065 (comment) ? |
@rbovard If you can, could you try a nightly build ? |
I can try |
Also see #49775 |
@nicogodet I just tried |
Any objections for me to close this issue in favor of people re-opening issues to cover individual incompatibilities? This PR (#54078) as well as other commits pushed in the last week have fixed the majority of issues raised here. |
@nirvn I think that makes sense! |
What is the bug or the crash?
There are various places in QGIS where the text is not switched to a light colour resulting in unreable text in the UI, Maybe we should gather up all the dark theme issues to make it a more usable experince.
See also #33079
Steps to reproduce the issue
Open style manager for single symbol renderer - though the problem is all over the show in QGIS.
Versions
QGIS Master and backwards
Supported QGIS version
New profile
Additional context
No response
The text was updated successfully, but these errors were encountered: