Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertex tool triggers layer.geometryChanged three times #47595

Closed
2 tasks done
uclaros opened this issue Mar 1, 2022 · 1 comment · Fixed by #50109 or #53632
Closed
2 tasks done

Vertex tool triggers layer.geometryChanged three times #47595

uclaros opened this issue Mar 1, 2022 · 1 comment · Fixed by #50109 or #53632
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Digitizing Related to feature digitizing map tools or functionality PyQGIS Related to the PyQGIS API Regression Something which used to work, but doesn't anymore

Comments

@uclaros
Copy link
Contributor

uclaros commented Mar 1, 2022

What is the bug or the crash?

Any edit done with the vertex tool causes the underlying vector layer to emit the geometryChanged signal three times instead of one.
@lbartoletti could be related to #44198 since it is also caused by your changes in #41658

Steps to reproduce the issue

  1. add a vector layer
  2. connect its geometryChanged signal to some function
  3. use the vertex tool to edit a single vertex
  4. the function is called three times (instead of one)

Versions

bcdb670, all versions since #41658

Supported QGIS version

  • I'm running a supported QGIS version according to the roadmap.

New profile

  • I tried with a new QGIS profile

Additional context

No response
@uclaros uclaros added PyQGIS Related to the PyQGIS API Regression Something which used to work, but doesn't anymore Bug Either a bug report, or a bug fix. Let's hope for the latter! Digitizing Related to feature digitizing map tools or functionality labels Mar 1, 2022
olivierdalang added a commit to opengisch/autocurve that referenced this issue Mar 23, 2022
@olivierdalang
use sets instead of lists
30dd5ab 
avoids duplicate changed_fids as it seems QGIS 3.22 triggers
geometry changed multiple times

see qgis/QGIS#47595
@Koyaani Koyaani mentioned this issue Sep 6, 2022
Merged
@uclaros uclaros reopened this Nov 30, 2022
@uclaros
Copy link
Contributor Author

uclaros commented Nov 30, 2022

The issue was partially addressed, now two signals are fired when avoid overlaps take place on an edit.

@troopa81 troopa81 mentioned this issue Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Digitizing Related to feature digitizing map tools or functionality PyQGIS Related to the PyQGIS API Regression Something which used to work, but doesn't anymore
Projects
None yet
Milestone
No milestone
1 participant
@uclaros