Build fails with WITH_POSTGRESQL=OFF

[kannes]

What is the bug or the crash?

Building QGIS fails for me if I disable WITH_POSTGRESQL because libpq-fe.h is not being found:

[ 88%] Building CXX object tests/src/providers/CMakeFiles/test_provider_postgresprovider.dir/test_provider_postgresprovider_autogen/mocs_compilation.cpp.o
[ 88%] Building CXX object tests/src/providers/CMakeFiles/test_provider_postgresprovider.dir/testqgspostgresprovider.cpp.o
In file included from /home/user/QGIS/src/providers/postgres/qgspostgresexpressioncompiler.h:21,
                 from /home/user/QGIS/tests/src/providers/testqgspostgresexpressioncompiler.cpp:19:
/home/user/QGIS/src/providers/postgres/qgspostgresconn.h:35:10: fatal error: libpq-fe.h: Datei oder Verzeichnis nicht gefunden
   35 | #include <libpq-fe.h>
      |          ^~~~~~~~~~~~
compilation terminated.
make[2]: *** [tests/src/providers/CMakeFiles/test_provider_postgresexpressioncompiler.dir/build.make:90: tests/src/providers/CMakeFiles/test_provider_postgresexpressioncompiler.dir/testqgspostgresexpressioncompiler.cpp.o] Fehler 1
make[1]: *** [CMakeFiles/Makefile2:26273: tests/src/providers/CMakeFiles/test_provider_postgresexpressioncompiler.dir/all] Fehler 2
make[1]: *** Auf noch nicht beendete Prozesse wird gewartet …
[ 88%] Building CXX object src/gui/CMakeFiles/qgis_gui.dir/processing/models/qgsmodelinputreorderwidget.cpp.o
[ 88%] Building CXX object src/gui/CMakeFiles/qgis_gui.dir/processing/models/qgsmodelsnapper.cpp.o
[ 88%] Building CXX object src/gui/CMakeFiles/qgis_gui.dir/processing/models/qgsmodelundocommand.cpp.o
In file included from /home/user/QGIS/src/providers/postgres/qgspostgresprovider.h:23,
                 from /home/user/QGIS/tests/src/providers/testqgspostgresprovider.cpp:20:
/home/user/QGIS/src/providers/postgres/qgspostgresconn.h:35:10: fatal error: libpq-fe.h: Datei oder Verzeichnis nicht gefunden
   35 | #include <libpq-fe.h>
      |          ^~~~~~~~~~~~
compilation terminated.
make[2]: *** [tests/src/providers/CMakeFiles/test_provider_postgresprovider.dir/build.make:90: tests/src/providers/CMakeFiles/test_provider_postgresprovider.dir/testqgspostgresprovider.cpp.o] Fehler 1
make[1]: *** [CMakeFiles/Makefile2:26301: tests/src/providers/CMakeFiles/test_provider_postgresprovider.dir/all] Fehler 2

Steps to reproduce the issue

1. Set WITH_POSTGRESQL=OFF
2. make
3. See the build fail

Versions

Recent master, a87893b

Supported QGIS version

• I'm running a supported QGIS version according to the roadmap.

New profile

• I tried with a new QGIS profile

Additional context

Ubuntu 22.04.1 LTS

[kannes]

I can NOT reproduce it on Archlinux with ninja with today's master:

...
  cmake -G "Ninja" ../ \
    -DCMAKE_INSTALL_PREFIX=/opt/$pkgname \
    -DCMAKE_BUILD_TYPE=RelWithDebInfo \
    -DQGIS_MANUAL_SUBDIR=share/man \
    -DENABLE_TESTS=FALSE \
    -DWITH_3D=TRUE \
    -DWITH_PDAL=TRUE \
    -DWITH_POSTGRESQL=FALSE

  ninja
...

[troopa81]

I can NOT reproduce it on Archlinux with ninja with today's master

Do you still have the issue on Ubuntu with current master?

[kannes]

Yes, just tested with current master.

[kannes]

Thanks! I can confirm that it builds now.