wkbType of geometries is not same as the layer with z and with geopackage

[Koyaani]

What is the bug or the crash?

When geometries are fetch from a Geopackage table with Z, the wkbType of geometries are 25D type (0x80000001) while the wkbType of the layer is Z (10XX). The problem is not present with other providers like shapefile or PostGis, nor when there is no Z or when there is ZM.

Steps to reproduce the issue

1. Create a new table in a Geopackage with Z (but without M)
2. Create a new geometry, but without save the layer
3. Open the python console and execute [f.geometry().wkbType() for f in iface.activeLayer().getFeatures()]
   -> The print displays : [1003]
4. Save the layer
5. Execute [f.geometry().wkbType() for f in iface.activeLayer().getFeatures()]
   -> The print displays : [-2147483645]
6. Execute iface.activeLayer().wkbType()
   -> The print displays : 1003

Peek.15-09-2022.15-11.webm

Versions

3.22, 3.26 and master

Supported QGIS version

• I'm running a supported QGIS version according to the roadmap.

New profile

• I tried with a new QGIS profile

Additional context

No response

[lbartoletti]

I guess there is a problem with the cast to the Qgs Wkb Type from the OGR one.

Something like this, works for me:

diff --git a/src/core/qgsogrutils.cpp b/src/core/qgsogrutils.cpp
index 3ff54b3e52a..d024be52356 100644
--- a/src/core/qgsogrutils.cpp
+++ b/src/core/qgsogrutils.cpp
@@ -628,7 +628,7 @@ std::unique_ptr< QgsMultiPoint > ogrGeometryToQgsMultiPoint( OGRGeometryH geom )

 std::unique_ptr< QgsLineString > ogrGeometryToQgsLineString( OGRGeometryH geom )
 {
-  QgsWkbTypes::Type wkbType = static_cast<QgsWkbTypes::Type>( OGR_G_GetGeometryType( geom ) );
+  QgsWkbTypes::Type wkbType = QgsOgrUtils::ogrGeometryTypeToQgsWkbType( OGR_G_GetGeometryType( geom ) );

   int count = OGR_G_GetPointCount( geom );
   QVector< double > x( count );

[lbartoletti]

@rouault I wonder why it works for shapefile and the geopackage needs a “better” cast?

[rouault]

@rouault I wonder why it works for shapefile and the geopackage needs a “better” cast?

I'm not sure either, but your fix looks good to me

[lbartoletti]

@rouault I wonder why it works for shapefile and the geopackage needs a “better” cast?

Because Shapefile use ZM and not only Z.