Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Longer opening time of GPKG file in newer versions. GPKG file with empty layers is opening much longer than gpkg containing layers filled with feature in the latest versions. #53525

Closed
2 tasks done
Kamzarr opened this issue Jun 20, 2023 · 2 comments · Fixed by #53566
Assignees
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Data Provider Related to specific vector, raster or mesh data providers Regression Something which used to work, but doesn't anymore

Comments

@Kamzarr
Copy link

Kamzarr commented Jun 20, 2023

What is the bug or the crash?

In newer versions opening geopackage with a lot of layers and opening project saved with this geopackage, takes longer and longer.
I have two geopackage files. One is geopackage with 300 empty layers without any features. Second one is similar but every layer contains one feature with geometry.

First problem is, that in newer versions of Qgis opening this gpkg files take longer than in previous version. For example in my case:
In versions 3.22.5 and 3.24.0 opening geopackage files with 300 layers take 30 seconds. (both filled and empty layers)
In versions 3.26.0 and 3.28.0 it takes 50 seconds to open.
in versions 3.28.7 and 3.30.0 it takes 1 min 40 seconds to open geopackage containig layers filled with features, but there is second problem in this versions. When opening geopackage with empty layers it takes 5 minutes to open!

Similar problem of longer and longer opening times accour when i open projects saved with these layers.

Steps to reproduce the issue

opening gpkg file:
gpkg_files.zip (or optionally create two gpkg files: one with 300 empty layers, second with 300 layers, every layer filled with one feature with geometry)

  1. open attached GPKG files by dragging them to qgis
  2. select all and click 'Add Layers'
  3. see difference of opening times depending on versions
  4. in version 3.28.7 and 3.30.0 see difference of opening time between empty and filled GPKG

opening project:

in different versions:
5. save project
6. open saved project and see difference of opening time depending of version

Versions

At least from 3.26.0 to 3.30.0. The worst in 3.28.7 to 3.30.0

Supported QGIS version

  • I'm running a supported QGIS version according to the roadmap.

New profile

Additional context

My computer:
Intel(R) Core(TM) i5-9300H CPU @ 2.40GHz 2.40 GHz
16 GB RAM
Windows 11

also tried on computer with Windows 10

@Kamzarr Kamzarr added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Jun 20, 2023
@agiudiceandrea agiudiceandrea added the Data Provider Related to specific vector, raster or mesh data providers label Jun 20, 2023
@agiudiceandrea
Copy link
Contributor

Maybe @rouault has some clue about this issue.

@agiudiceandrea agiudiceandrea added the Regression Something which used to work, but doesn't anymore label Jun 20, 2023
@rouault rouault self-assigned this Jun 23, 2023
rouault added a commit to rouault/QGIS that referenced this issue Jun 23, 2023
rouault added a commit to rouault/QGIS that referenced this issue Jun 23, 2023
@rouault
Copy link
Contributor

rouault commented Jun 23, 2023

fix in #53566 . Opening time goes down to ~ 10 s on my machine

rouault added a commit to rouault/QGIS that referenced this issue Jun 23, 2023
rouault added a commit to rouault/QGIS that referenced this issue Jun 23, 2023
rouault added a commit to rouault/QGIS that referenced this issue Jul 6, 2023
rouault added a commit to rouault/QGIS that referenced this issue Jul 6, 2023
nyalldawson pushed a commit that referenced this issue Jul 18, 2023
nyalldawson pushed a commit that referenced this issue Jul 18, 2023
)

Prevent datasets from being released too early.
rouault added a commit to rouault/QGIS that referenced this issue Jul 18, 2023
rouault added a commit to rouault/QGIS that referenced this issue Jul 18, 2023
rouault added a commit to rouault/QGIS that referenced this issue Jul 18, 2023
rouault added a commit to rouault/QGIS that referenced this issue Jul 18, 2023
nyalldawson pushed a commit that referenced this issue Jul 19, 2023
nyalldawson pushed a commit that referenced this issue Jul 19, 2023
)

Prevent datasets from being released too early.
nyalldawson pushed a commit that referenced this issue Jul 19, 2023
nyalldawson pushed a commit that referenced this issue Jul 19, 2023
)

Prevent datasets from being released too early.
nyalldawson pushed a commit that referenced this issue Jul 25, 2023
nyalldawson pushed a commit that referenced this issue Jul 25, 2023
)

Prevent datasets from being released too early.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Data Provider Related to specific vector, raster or mesh data providers Regression Something which used to work, but doesn't anymore
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants