Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add part to geometryless feature does not work on single curvepolygon layer #57255

Closed
1 of 2 tasks
3nids opened this issue Apr 26, 2024 · 7 comments · Fixed by #57636
Closed
1 of 2 tasks

add part to geometryless feature does not work on single curvepolygon layer #57255

3nids opened this issue Apr 26, 2024 · 7 comments · Fixed by #57636
Assignees
@nirvn
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!

Comments

@3nids
Copy link
Member

3nids commented Apr 26, 2024

What is the bug or the crash?

add part map does not work for single curvepolygon layers when trying to add part to geometryless feature

Steps to reproduce the issue

create a curvepolygon memory layer
create a geometryless feature from the attribute table
select it
try to add part

Versions

at least 3.34+

Supported QGIS version

  • I'm running a supported QGIS version according to the roadmap.

New profile

Additional context

No response
@3nids 3nids added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Apr 26, 2024
@ponceta ponceta mentioned this issue Apr 26, 2024
Merged
7 tasks
@3nids
Copy link
Member Author

3nids commented Apr 26, 2024

it seems to be fixed in master by 71f3cc7

This was referenced Apr 26, 2024
Merged
Merged
Djedouas added a commit to Djedouas/QGIS that referenced this issue May 31, 2024
@Djedouas
Use WkbType instead of GeometryType enum for addPart
4533064 
Deprecating QgsGeometry::addPart in favor of QgsGeometry::addPartV2
to use Qgis::WkbType instead of Qgis::GeometryType because the latter
can't handle curved geometries (not specific enough).

Fixes qgis#57255
Djedouas added a commit to Djedouas/QGIS that referenced this issue May 31, 2024
@Djedouas
Add addPartWkbType and use it for QgsCurve addPart
85fa8e5 
Fixes qgis#57255.

Dedicated PR will be submitted for master branch
that will aim deprecate all addPart methods of
QgsGeometry and create equivalents V2, using
more precise Qgis::WkbType instead of Qgis::GeometryType.
@Djedouas Djedouas mentioned this issue May 31, 2024
Merged
3nids pushed a commit to 3nids/QGIS that referenced this issue Jun 3, 2024
@Djedouas
Add addPartWkbType and use it for QgsCurve addPart (#89)
132434a 
Fixes qgis#57255.

Dedicated PR will be submitted for master branch
that will aim deprecate all addPart methods of
QgsGeometry and create equivalents V2, using
more precise Qgis::WkbType instead of Qgis::GeometryType.
Djedouas added a commit to Djedouas/QGIS that referenced this issue Jun 3, 2024
@Djedouas
Use WkbType instead of GeometryType enum for addPart
bbe249b 
Deprecating QgsGeometry::addPart in favor of QgsGeometry::addPartV2
to use Qgis::WkbType instead of Qgis::GeometryType because the latter
can't handle curved geometries (not specific enough).

Fixes qgis#57255
Djedouas added a commit to Djedouas/QGIS that referenced this issue Jun 3, 2024
@Djedouas
Use WkbType instead of GeometryType enum for addPart
643f9d8 
Deprecating QgsGeometry::addPart in favor of QgsGeometry::addPartV2
to use Qgis::WkbType instead of Qgis::GeometryType because the latter
can't handle curved geometries (not specific enough).

Fixes qgis#57255
lbartoletti pushed a commit that referenced this issue Jun 3, 2024
@Djedouas @lbartoletti
Use WkbType instead of GeometryType enum for addPart
ab663b4 
Deprecating QgsGeometry::addPart in favor of QgsGeometry::addPartV2
to use Qgis::WkbType instead of Qgis::GeometryType because the latter
can't handle curved geometries (not specific enough).

Fixes #57255
@ponceta
Copy link

ponceta commented Jun 4, 2024

@lbartoletti is it fixed in nightly?

Because testing it with latest nightly give me this behaviour :

  • Commit a polygon drawn in a curvepolygonz can be added as geometry part (scenario 4)
  • Commit a curvepolygon drawn in a curvepolygonz keep the same error message as before (scenario 3)
    image

(Scenarii are described in #57261 (comment))

@3nids
Copy link
Member Author

3nids commented Jun 4, 2024

@Djedouas this means we probably need to drop the flatType call?

@3nids
Copy link
Member Author

3nids commented Jun 4, 2024

and we need to extend the map tool test with this scenario

@Djedouas Djedouas reopened this Jun 4, 2024
@Djedouas
Copy link
Member

Djedouas commented Jun 4, 2024

@Djedouas this means we probably need to drop the flatType call?

Not sure, I don't think that it's related to the Z part of the geometry. Looking into this.

@Djedouas
Copy link
Member

Djedouas commented Jun 4, 2024

Using the Windows build from the PR #57636 (comment) each scenario works.

The nightly build is on commit 5481dab which is older than our fix.

lbartoletti pushed a commit that referenced this issue Jun 4, 2024
@Djedouas @lbartoletti
Add addPartWkbType and use it for QgsCurve addPart (#89)
27266a2 
Fixes #57255.

Dedicated PR will be submitted for master branch
that will aim deprecate all addPart methods of
QgsGeometry and create equivalents V2, using
more precise Qgis::WkbType instead of Qgis::GeometryType.
@ponceta
Copy link

ponceta commented Jun 25, 2024

I can confirm it is fixed in QGIS 3.34.8 and Master (two different fixes)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nirvn nirvn

Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use WkbType instead of GeometryType for addPart Djedouas/QGIS
5 participants
@3nids @nirvn @lbartoletti @ponceta @Djedouas