Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_provider_postgresprovider TestPyQgsPostgresProvider.testExtent doesn't test extent #57818

Closed
2 tasks
strk opened this issue Jun 21, 2024 · 1 comment · Fixed by #57829
Closed
2 tasks
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! testsuite Issue related to testsuite

Comments

@strk
Copy link
Contributor

strk commented Jun 21, 2024

What is the bug or the crash?

The TestPyQgsPostgresProvider.testExtent test in tests/src/python/test_provider_postgres.py doesn't seem to be really testing anything about extent

Steps to reproduce the issue

ehm... break extent computation, run the test, see it succeed ?

Versions

current master 2b19839

Supported QGIS version

  • I'm running a supported QGIS version according to the roadmap.

New profile

Additional context

Found while working on a geography extent test as per #57514 (comment)

@strk strk added Bug Either a bug report, or a bug fix. Let's hope for the latter! testsuite Issue related to testsuite labels Jun 21, 2024
@strk
Copy link
Contributor Author

strk commented Jun 21, 2024

Not only that, but the test is also not idempotent

strk added a commit to strk/QGIS that referenced this issue Jun 22, 2024
It was stubbed but not really testing anything.
Closes qgisGH-57818
strk added a commit to strk/QGIS that referenced this issue Jun 22, 2024
It was stubbed but not really testing anything.
Closes qgisGH-57818
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! testsuite Issue related to testsuite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant