do not insert layers in embedded groups #10004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonder-sk
reviewed
May 16, 2019
There was a problem hiding this comment.
It looks good to me, but would it be possible to extract the duplicated code for finding first non-embedded parent to a function in QgsLayerTreeUtils to avoid code duplication? It would also make the logic easier to read and possibly to have a unit test for that as well...
|
While you're addressing this -- a very similar issue is that sometimes layers get inserted into mutually exclusive groups. The fix would be almost identical to this one... |
|
Sorry, why would not have layers inserted into mutually exclusive groups? |
|
This is for the auto-insertion point when a new layer is added to a project, right? |
|
@nyalldawson yes, and I don't see what makes you think a layer should not end up there. |
3nids
force-pushed
the
fix21863
branch
2 times, most recently
from
473defe
to
2042ba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21863
not sure if this code (written twice here) would be better suited in
QgsLayerTreeRegistryBridge::setLayerInsertionPointwould be nice if some layer-tree aficionados would be looking into this one ;)