Join GitHub today
Fix identify on map in relation reference widget #10047
@m-kuhn thank you for looking at this PR, I think that the error was due to a wrong assumption about the underlying model: the original code assumed the model was an instance of
I didn't check if that error was introduced by a change of the underlying model, it dates 3 years back, what surprises me is that this bug went unnoticed for such a long time.
In any event I added a test case (which failed before my patch and passes after the patch).
The backport to
To backport manually, run these commands in your terminal:
# Fetch latest updates from GitHub. git fetch # Create new working tree. git worktree add .worktrees/backport release-3_4 # Navigate to the new directory. cd .worktrees/backport # Cherry-pick all the commits of this pull request and resolve the likely conflicts. git cherry-pick 2b14dacd51ca98061d7f14877df74006fd52e5c4 ad019c499bcd8d9800d9e7bafbcebad48d678bb2 # Create a new branch with these backported commits. git checkout -b backport-10047-to-release-3_4 # Push it to GitHub. git push --set-upstream origin backport-10047-to-release-3_4 # Go back to the original working tree. cd ../.. # Delete the working tree. git worktree remove .worktrees/backport
Then, create a pull request where the