Fix identify on map in relation reference widget #10047
Conversation
Fixes qgis#22071 - Relation reference widget wrong feature when "on map identification"
|
@m-kuhn I'd like your blessing here. |
|
Do you have some information what was wrong with the previous approach? Reading the code, both approaches seem to make sense, so I'd be happy to get a bit of context as a decision aid. |
|
@m-kuhn thank you for looking at this PR, I think that the error was due to a wrong assumption about the underlying model: the original code assumed the model was an instance of I didn't check if that error was introduced by a change of the underlying model, it dates 3 years back, what surprises me is that this bug went unnoticed for such a long time. In any event I added a test case (which failed before my patch and passes after the patch). |
| QEventLoop loop; | ||
| // Populate model (I tried to listen to signals but the module reload() runs twice | ||
| // (the first load triggers a second one which does the population of the combo) | ||
| // and I haven't fin a way to properly wait for it. |
There was a problem hiding this comment.
Maybe casting the combobox to a QgsFeatureListComboBox and then connecting to the models isLoadingChanged signal?
But it's not trivial
There was a problem hiding this comment.
Maybe casting the combobox to a
QgsFeatureListComboBoxand then connecting to the modelsisLoadingChangedsignal?
But it's not trivial
I tried that, but the isLoadingChanged was triggered twice as well (4 times, really), and I missed the second reload (which actually loads the data in the combo), but I admit that the logic in that loading behavior is not clear to me. I thought about adding another signal but I'm not sure it would be useful out of the test, so I prefer to not add it.
There was a problem hiding this comment.
IIRC: The logic is to as quickly as possible get the display value of the current selected item to show up to the user. And then with a little delay lazy-load also some additional values to fill the popup.
There was a problem hiding this comment.
Maybe connecting to the signal and then checking if the rowCount of the model is > 1?
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport release-3_4
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick 2b14dacd51ca98061d7f14877df74006fd52e5c4 ad019c499bcd8d9800d9e7bafbcebad48d678bb2
# Create a new branch with these backported commits.
git checkout -b backport-10047-to-release-3_4
# Push it to GitHub.
git push --set-upstream origin backport-10047-to-release-3_4
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backportThen, create a pull request where the |
Fixes #22071 - Relation reference widget wrong feature when "on map identification"