Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maptips] restore wrapping of the long lines (fix #21388) #10081

Merged
merged 1 commit into from May 24, 2019
Merged

[maptips] restore wrapping of the long lines (fix #21388) #10081

merged 1 commit into from May 24, 2019

Conversation

alexbruy
Copy link
Contributor

Description

Currently maptips shown as single line, no word-wrapping allowed and this does not work well with long text, it gets truncated and not visible. This restores previous behavior with enabled wrapping.

Fixes https://issues.qgis.org/issues/21388

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@alexbruy
Copy link
Contributor Author

@nirvn your feedback is more than welcome, as nowrap was added in one of the your commits

@nirvn
Copy link
Contributor

nirvn commented May 23, 2019

@alexbruy , thanks for the heads up, I'll look at this tomorrow.

@nirvn
Copy link
Contributor

nirvn commented May 24, 2019

@alexbruy , so looked into this early this morning. It doesn't break complex HTML maptips, so that's good.

The only downside I'm seeing is that the white space wrapping ends up wrapping most more-than-one-word maptips string; for e.g.:
image

I guess that's a small price to pay for being slightly more compatible out of the box. One can always use the HTML maptips to add a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants