Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processing] do not declare output of saveselectedfeatures as points #10093

Merged
merged 1 commit into from May 26, 2019

Conversation

@volaya
Copy link
Contributor

commented May 24, 2019

Description

Algorithm output can be of any geometry type

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@volaya volaya requested a review from nyalldawson May 24, 2019

@@ -29,7 +29,7 @@ void QgsSaveSelectedFeatures::initAlgorithm( const QVariantMap & )
{
addParameter( new QgsProcessingParameterVectorLayer( QStringLiteral( "INPUT" ), QObject::tr( "Input layer" ),

This comment has been minimized.

Copy link
@alexbruy

alexbruy May 24, 2019

Contributor

Not related to this PR, but I'm wondering why we use QgsProcessingParameterVectorLayer here instead of feature source which is more flexible?

This comment has been minimized.

Copy link
@volaya

volaya May 24, 2019

Author Contributor

Looks like it was directly adapted from the old QGIS2 code, and that change was overlooked

This comment has been minimized.

Copy link
@nyalldawson

nyalldawson May 26, 2019

Contributor

It's because it works directly with QgsVectorLayer methods -- i.e. directly accesses the selected features from the layer. Feature source parameters themselves have no knowledge of selections, they just get a bunch of features and it's the parameter value which determines whether these are the selected features only.

@nyalldawson nyalldawson merged commit c3cfcad into qgis:master May 26, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.