New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all composer related tests (plus a bonus feature) #1044
Conversation
I should mention that I'd love a speedy review on this one -- the current state of the test suite is really hampering my development work! :) |
Manually applied |
Thanks @nyalldawson Jenkins still seems to not be building automatically properly - I am looking in to why. FYI I started it manually again and get this list of failing tests:
I will check and add anomaly files where I can. Note the build was against 21d3fe1 |
@timlinux That's a known issue - it's somewhat related to http://hub.qgis.org/issues/8993 . Basically the map frame and annotations are being drawn outside of the item bounds, which causes artefacts like this. It's on my to-repair list. |
The composer test suit is in bad shape at the moment. This pull request fixes all composer related tests which are currently failing. First it reworks qgscompositionchecker to derive from renderchecker (#9117), so that anomaly images can be set for composer tests (the old method of allowing a set number of differing pixels was too inflexible and allowed tests to pass when they shouldn't be, eg the composermap zebra style test). Then I've reworked all the compositionchecker related tests so that they all pass, in some cases adding anomaly images or fixing the underlying bugs.
It also adds a new feature required to fix the failing zebra style test (#8767), which is the ability to set the pen and colours used in zebra style maps.
The composer html tests had to be fixed by forcing the test html file to use a set pixel based font size and the expected images regenerated. This may mean they will currently fail on non-linux platforms, but fixing this will be a simple matter of adding anomaly images for these platforms.