model/view for layer/field selectors #1289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a model/view for selecting layers and eventually their corresponding fields.
The models can be used directly on top of widgets.
Anyway, I implement sub-classes of QComboBox since the connection between layer and fields models can only be made by the selection model. And, having the field model changed by a change in selection in the layer combo is not a good idea (it must be changed on currentItemChanged and not selection changed).
For testing, I implemented these model in two places:
Also, my intention is to extend the field model and combo to handle expressions (since it is used in many places).
Thanks a lot to @NathanW2 for his initial python model: https://gist.github.com/NathanW2/d2bf29d9043c5658dab2
and to @wonder-sk for his advices.