Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add preview modes for composer - needs feedback! #1294

Closed
wants to merge 1 commit into from

Conversation

nyalldawson
Copy link
Collaborator

This pull request adds a new QGraphicsEffect to QGIS for simulating grayscale, monochrome and color blindness (see http://hub.qgis.org/issues/9886 for the original inspiration). I've added it to the composer, so that interactive previews in any of these modes are possible. It should also be possible to add this effect to the map canvas so that map layer symbology can be tweaked with immediate feedback.

HOWEVER - there's an issue somewhere in the code which I can't track down (or replicate). In Nathan's testing switching on any of the preview modes stops the composer view widget from repainting (effectively freezing the control) until the effect is disabled. I've tested on a range of windows and linux environments but can't reproduce this or figure out what is happening. So, any advice on what is going wrong here would be appreciated

@nirvn
Copy link
Contributor

nirvn commented Apr 18, 2014

Nyall, very useful. I'd love to see an ebook preview mode too, finding myself producing maps specifically for that type of media more & more. Amazon has a free app to show what images would look like on an ebook reader, that'd be your point of reference. Cheers.

@mhugent
Copy link
Contributor

mhugent commented May 12, 2014

Assigned to @NathanW2

@NathanW2
Copy link
Member

Nyall and I will try to work though this one. I'm really not sure why it
doesn't work on my Windows build but does on Nyalls

On Mon, May 12, 2014 at 5:12 PM, mhugent notifications@github.com wrote:

Assigned to @NathanW2 https://github.com/NathanW2


Reply to this email directly or view it on GitHubhttps://github.com//pull/1294#issuecomment-42801859
.

@nyalldawson
Copy link
Collaborator Author

@NathanW2 I've just rebased this against master - do you mind testing and seeing if you still have issues? if so, we'll take this conversation offline and try again to debug....

…ser in grayscale, monochrome and color blindness simulation modes prior to printing (refs qgis#9886)
@nyalldawson
Copy link
Collaborator Author

Merged and confirmed working for Nathan!

@nyalldawson nyalldawson deleted the composer_preview_modes3 branch May 29, 2014 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants