Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #10405 and #10303 partially: removes the scroll area for the style page #1428

Merged
merged 1 commit into from
Jun 6, 2014

Conversation

3nids
Copy link
Member

@3nids 3nids commented Jun 6, 2014

This remove the scroll area in the style page of the vector layer properties.
I think if scroll is needed it should be done in the corresponding subpages (such as point displacement, categorized, etc).

3nids added a commit that referenced this pull request Jun 6, 2014
fix #10405 and #10303 partially: removes the scroll area for the style page
@3nids 3nids merged commit 92dafa6 into qgis:master Jun 6, 2014
@3nids 3nids deleted the fix10405 branch June 6, 2014 13:09
@dakcarto
Copy link
Member

dakcarto commented Jun 7, 2014

@3nids I don't think this is the appropriate fix, and should be reverted. The fix should be within the combobox widget itself, e.g. limit its width, self-adjusting if needed, etc.

Now the Vector properties dialog is way too wide, especially when viewing symbology. When switching to symbology, if the dialog is not wide enough, the icon sidebar is now forced to icon mode, and can not have its splitter moved until the dialog is made bigger. Also, resizing the dialog now forces resizing of the sidebar. The previous main scroll area kept this from happening.

Alternatively, a scroll area could be added to symbology, but that is not much different than reverting this, and does not address the sidebar resizing issue.

Also, you gave no time for anyone to test this before pushing it. The PR was up for only 7 hours!

@3nids
Copy link
Member Author

3nids commented Jun 11, 2014

@dakcarto hi, sorry for not letting up long enough. I reverted this and set up a maximum width of 500px for the widget in categorized and graduated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants