Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fine grain control over select by location tools #1495

Merged
merged 3 commits into from
Jul 1, 2014
Merged

Add fine grain control over select by location tools #1495

merged 3 commits into from
Jul 1, 2014

Conversation

giohappy
Copy link
Contributor

This adds fine grained control on what kined of spatial relation the selection will be done (touch, overlap, within). This applies to Vector fTools select by location, and Processing fTools algorithms (select and extract by location)

@gioman
Copy link
Contributor

gioman commented Jun 30, 2014

assigned @volaya @alexbruy

@volaya
Copy link
Contributor

volaya commented Jul 1, 2014

The Processing part look great to me, so it can be merged. Let's wait to see if @alexbruy can check the fTools code and give us green light to merge it all.

Great work!

alexbruy added a commit that referenced this pull request Jul 1, 2014
Add fine grain control over select by location tools
@alexbruy alexbruy merged commit dd4c1d1 into qgis:master Jul 1, 2014
@alexbruy
Copy link
Contributor

alexbruy commented Jul 1, 2014

Good job, thanks!

@NathanW2
Copy link
Member

NathanW2 commented Jul 1, 2014

Do you think it's worth just calling the processing framework tools under
the hood in fTools. Seems crazy to duplicate all the logic.

On Tue, Jul 1, 2014 at 10:40 PM, alexbruy notifications@github.com wrote:

Merged #1495 #1495.


Reply to this email directly or view it on GitHub
#1495 (comment).

@giohappy
Copy link
Contributor Author

giohappy commented Jul 1, 2014

In the process of moving all the Vector menu tools to Processing I agree we should avoid this duplication. In the meanwhile I think we should keep both. IMHO all or nothing, otherwise the user could be confused by the different kind of GUIs

@giohappy giohappy deleted the new_operators_dospatialjoin branch July 1, 2014 13:15
@gioman
Copy link
Contributor

gioman commented Feb 3, 2015

Can you have a look to http://hub.qgis.org/issues/11738 ? it seems is a regression caused by this commit. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants