Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[processing] JoinAttributes improvement #1498

Merged
merged 2 commits into from
Jul 5, 2014
Merged

[processing] JoinAttributes improvement #1498

merged 2 commits into from
Jul 5, 2014

Conversation

minorua
Copy link
Contributor

@minorua minorua commented Jul 5, 2014

This commit will improve the JoinAttributes algorithm.

  • Allows join not only with vector attribute table but also with geometryless table. Provides a way to join table without field name prefix.
  • Improves performance by caching the records of join table.
  • Avoids join failures due to the data type difference by comparing keys as unicode string.
  • Fixes UnicodeEncodeError that occurs if key field name includes non-ASCII characters.

@minorua
[processing] JoinAttributes improvement
361202e 
- allow join not only with vector attribute table but also with geometryless table
- performance and key comparison improvement
- str to unicode fix
@minorua
[processing] fix join to layer with join (fix qgis#10244)
228892c
@gioman
Copy link
Contributor

gioman commented Jul 5, 2014

assigned @volaya @alexbruy

alexbruy added a commit that referenced this pull request Jul 5, 2014
@alexbruy
Merge pull request #1498 from minorua/joinattrs
a3c8289 
[processing] JoinAttributes improvement
@alexbruy alexbruy merged commit a3c8289 into qgis:master Jul 5, 2014
@anitagraser
Copy link
Member

This seems to cause an issue: http://hub.qgis.org/issues/11694

@qgib qgib mentioned this pull request May 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@minorua @gioman @anitagraser @alexbruy