Use appropriate buffer for QgsGeometry::XXXContainedInLine. Fix #10999. #1609
Conversation
arnaud-morvan
force-pushed
the
reshape_at_high_scale
branch
from
a6ba41d
to
db37c87
Compare
|
Tested with Arnaud, and discussed with Giovanni Manghi, I think it is a good compromise to avoid heavy refactoring of the logic of the QgsGeometry::XXXContainedInLine functions. |
arnaud-morvan
force-pushed
the
reshape_at_high_scale
branch
from
db37c87
to
03829a4
Compare
| emit messageEmitted( tr( "An error occurs during the reshaping, capture has been cancelled" ), QgsMessageBar::WARNING ); | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
That exception has been addressed recently in 37f1a1 in a slightly better way (handling directly GEOS exception, not any exception). Also, at this point we should not add new translatable strings unless necessary.
There was a problem hiding this comment.
It's necessary to release the capture, without this you have to close QGIS to get back the maptoolreshape to work correctly.
There was a problem hiding this comment.
But with recent changes (see the referenced commit 37f1a1) this is already handled gracefully on a lower level (reshapeGeometry returns 1)
We have reduced the problem by reducing the size of the buffer used in QgsGeometry::XXXContainedInLine functions.
The error may still occur depending on:
the accuracy of the projection used,
the distance between the object to modify and the nearest point.
So we caught the error, stop capturing and displaying a more specific message.