LayerTree - keep checkstate of the moved layer

[slarosa]

refs: http://hub.qgis.org/issues/11382

the current behavior does not keep the state of the moved layer when you call the moveLayer method, the layer will always be visible (checked), I think it make more sense to keep the checkstate of the layer when moved to group.

The below snippet does the layer vl visible altough you call setLayerVisible(vl, False)

vl = iface.activeLayer()
legend = iface.legendInterface()

myGroup = legend.addGroup("myGroup", False)
legend.setLayerVisible(vl, False)
legend.moveLayer(vl, myGroup)

with the patch the vl layer will be unchecked into layer tree.

[strk]

May I suggest separating the API/ABI-breaking commit from the one that fixes the behavioural breakage ?

[slarosa]

Hi @strk,
commits would have to be squashed, the API break was solved with 27e8897 by adding default value.

Maybe for now we can cohabit with the current behavior, keeping open this request waiting for more feedback, the release is very close!

[wonder-sk]

Fixed the problem in a bit better way with 3546b32 - anyway thanks for the pull request!