-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix glitch on mouse-wheel zoom event #1732
Conversation
The person to consult here is @wonder-sk . I haven't tested the proposed fix but what should not happen is for the pre-rendering temporary paint to be removed. On slow computers it really enhance the user experience. |
pre-rendering paint is not removed by the change |
Travis fails against an unrelated test which is also failing in master as of d84af0d: FAIL! : TestZipLayer::testZipItemRaster() 'testZipItem( QDir::tempPath() + "/testzip.zip", "landsat_b1.tif" )' returned FALSE. () @blazek your commit was first failing, ideas ? Need a separate ticket for that ? See https://travis-ci.org/qgis/QGIS/builds/43823913 |
Pushed as 40e0d78 |
NOTE: the fix was reverted as it broke proper rendering of rotated map. It really needs be done at the renderer side, to always pass a properly clipped image to setRect. That way it should work. I'll file another PR when ready with that approach (next week) |
TestZipLayer is fixed in 69b27f0 |
Sandro please don't push and then revert commits without reviews. On Sat, 13 Dec 2014 5:06 am Radim Blazek notifications@github.com wrote:
|
Sorry @NathanW2 I'll keep next PR for this open for review and avoid pushing it myself. |
Next PR is here: #1734 |
See http://hub.qgis.org/issues/11811