Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix glitch on mouse-wheel zoom event #1732

Closed
wants to merge 1 commit into from

Conversation

strk
Copy link
Contributor

@strk strk commented Dec 12, 2014

@nirvn
Copy link
Contributor

nirvn commented Dec 12, 2014

The person to consult here is @wonder-sk . I haven't tested the proposed fix but what should not happen is for the pre-rendering temporary paint to be removed. On slow computers it really enhance the user experience.

@strk
Copy link
Contributor Author

strk commented Dec 12, 2014

pre-rendering paint is not removed by the change

@strk
Copy link
Contributor Author

strk commented Dec 12, 2014

Travis fails against an unrelated test which is also failing in master as of d84af0d:

FAIL! : TestZipLayer::testZipItemRaster() 'testZipItem( QDir::tempPath() + "/testzip.zip", "landsat_b1.tif" )' returned FALSE. ()

@blazek your commit was first failing, ideas ? Need a separate ticket for that ? See https://travis-ci.org/qgis/QGIS/builds/43823913

@strk
Copy link
Contributor Author

strk commented Dec 12, 2014

Pushed as 40e0d78

@strk strk closed this Dec 12, 2014
@strk
Copy link
Contributor Author

strk commented Dec 12, 2014

NOTE: the fix was reverted as it broke proper rendering of rotated map. It really needs be done at the renderer side, to always pass a properly clipped image to setRect. That way it should work. I'll file another PR when ready with that approach (next week)

@blazek
Copy link
Member

blazek commented Dec 12, 2014

TestZipLayer is fixed in 69b27f0

@NathanW2
Copy link
Member

Sandro please don't push and then revert commits without reviews.

On Sat, 13 Dec 2014 5:06 am Radim Blazek notifications@github.com wrote:

TestZipLayer is fixed in 69b27f0
69b27f0


Reply to this email directly or view it on GitHub
#1732 (comment).

@strk
Copy link
Contributor Author

strk commented Dec 13, 2014

Sorry @NathanW2 I'll keep next PR for this open for review and avoid pushing it myself.

@strk
Copy link
Contributor Author

strk commented Dec 13, 2014

Next PR is here: #1734

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants