added QgsMessageBar::SUCCESS #1736
Conversation
| @@ -111,6 +111,9 @@ void QgsMessageBarItem::writeContent() | |||
| case QgsMessageBar::WARNING: | |||
| msgIcon = QString( "/mIconWarn.png" ); | |||
| break; | |||
| case QgsMessageBar::SUCCESS: | |||
| msgIcon = QString( "/mActionCheckQgisVersion.png" ); | |||
There was a problem hiding this comment.
Could you copy the icon and make a new one called mIconSuccess. Reusing is good but it would be nice to be able to change the success icon without changing the other.
|
Looks good to me. If you just update that icon you can merge it. |
|
@NathanW2 done. thanks for merging, I've no write rights |
|
@mbernasocchi Thanks for this! Positive message colors have been missing for a while, but it wasn't so obvious until you posted your PR. 😄 |
|
@dakcarto no prob :) another thing that is missing is a LayerSavedAs message (when saved as is successful), I have a branch but somehow I cant get it to make the emitted signal arrive to python (although I can connect to it and emit it from python). would you have a look at this branch: https://github.com/mbernasocchi/QGIS/tree/emit-saved-as |
|
@mbernasocchi I believe you also need to connect the app's signal to the interface's, to re-emit it from the interface. Here is where other signal-to-signal connections are located in the interface's implementation file. |
Added a new level of messages in QgsMessageBar for succesful messages. they are colored with the bootstrap success green (background #dff0d8; border #8e998a) reusing the mActionCheckQgisVersion.png icon.
@NathanW2 can you have a look? thanks