Add not-null option for osm export #2021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| void exportSpatiaLiteNodes( const QString& tableName, const QStringList& tagKeys ); | ||
| void exportSpatiaLiteWays( bool closed, const QString& tableName, const QStringList& tagKeys ); | ||
| void exportSpatiaLiteNodes( const QString& tableName, const QStringList& tagKeys, const QStringList& notNullTagKeys ); | ||
| void exportSpatiaLiteWays( bool closed, const QString& tableName, const QStringList& tagKeys, const QStringList& notNullTagKeys ); |
There was a problem hiding this comment.
Please make these new arguments optional (i.e. with default values being QStringList())
|
Also please make sure to run ./scripts/prepare-commit.sh to get the spacing and indentation of correct. |
|
I've created a new one #2026 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For examle you want to get layer with buildings from osm.
I've added Not null check-box column which allows to filter features during export, which have checked attributes