Write to project join memory cache property value instead of not cache is empty #2054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaud-morvan
force-pushed
the
join_memory_cache
branch
from
6fce92e
to
cb4d518
Compare
mhugent
added a commit
that referenced
this pull request
May 22, 2015
Write to project join memory cache property value instead of not cache is empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With existing behavior which write !joinIt->cachedAttributes.isEmpty() to project, if the joined table is empty, the memory cache fall down to false on project saving.
When using existing project with a new fresh database, this is very inconvenient.
It seems smarter to write the content of the memoryCache property.