Fix add part tool doesn't work #2305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regardless of the underlying layer geometry type, the tool was always reporting that geometries were not multipart
|
add part can't be used on a single part geometry layer. also, not sure it should be converted to multi, it should depend on the layer, no? |
|
@3nids but isn't that up to the provider to determine? Ie when the layer is saved? |
|
totally agree, but I get this warning: |
m-kuhn
added
the
Requires Changes!
|
Better fix incoming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regardless of the underlying layer geometry type, the tool was always reporting that geometries were not multipart. Now geometries are always converted to multipart when trying to add a part.