QgsFillSymbolLayerV2 descendants missing from sip

[endmax]

I've added the missing classes derived from QgsFillSymbolLayerV2, QgsLineSymbolLayerV2 and QgsMarkerSymbolLayerV2 to QGis Python API.
The definitions have been splitted over three different .sip files
Now the APIs cover the entire QgsSymbolLayer hierarchy.
See also http://osgeo-org.1560.n6.nabble.com/QgsFillSymbolLayerV2-descendants-missing-from-sip-tt5002739.html

[timlinux]

+1 on testing - thanks for these updates Massimo

[etiennesky]

I knew you'd say that! ;) Without testing, hard to test new sip bindings!

[endmax]

So, how do you suggest to test beside class instantiation ?
I mean, what is the goal of this test?

1. test if a class (functions and attributes) exist / is exposed as expected ?
2. test if a class behave as expected?
3. a mix of 1 and 2?

[timlinux]

There are a number of ways you can test.

• use a render check e.g. tests/src/core/testqgsrenderers.cpp (you can implement the same test methodology in python, as the QgsRenderChecker has python bindings too see tests/src/python/test_qgsrasterlayer.py for an example.
• simple instantiation using the provided api is a valid and useful way to verify that the api remains intact after changes
• in the case of symbology you could also instantiate a symbol and then write it to qml and then veify that the qml matches a known one (though this may be vulnerable to small changes in the serialisation format.

Regards

Tim

[endmax]

I'm preparing test for classes instantiation and I've discovered a missing conversion (in my code) from top level class to derived classes. I've solved the problem completing the ConvertToSubClassCode section in the main class.
Is the dynamyc_cast the most convenient way to test for inheritance ?
How can I upload a new version for this pull request?

[timlinux]

Hi

I believe if you commit to the same branch the updates will be automatic, otherwise close the pull request and create a new one after.

Thanks

Tim

[endmax]

I'm going to close this pull request and create a new one that will contain a test and some small changes.

[timlinux]

Great thanks Massimo!