Read source from provider before saving memory layer (fixes #8997) #2624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SebDieBln wow, that method is full of ugly provider specific handling! I guess one more can't hurt ;) Do you mind adding a test to test_provider_memory.py to cover this bug? |
|
@nyalldawson Good point, as ususal 😃 |
SebDieBln
force-pushed
the
SaveMemoryLayerFields
branch
from
85cd5f9
to
836ea81
Compare
nyalldawson
added a commit
that referenced
this pull request
Jan 1, 2016
Read source from provider before saving memory layer (fixes #8997)
|
@SebDieBln merged - thanks! |
This was referenced May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the memory provider saves field definitions within the source the source needs to be re-read before saving a memory-based vector layer.