append extension to output filename (fix #14077) #2680
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems some OGR drivers does not report extension via metadata, in such case we extract it from selected filter string
|
I think it would be better to fix this at the QgsVectorFileWriter::driverMetadata level instead of adding additional code in the various places a filename is picked. I've been testing with manisandro@93f12df and it seems to work fine. @m-kuhn What do you think? |
|
Sounds good to me @manisandro @alexbruy does the fix from manisandro/QGIS@93f12df work for you? If yes I'd say we merge it. |
|
Work fine here too. Feel free to close this PR and merge it. |
|
Ok, my commit is part of pull #2688 . |
|
Superseded by #2688 |
This was referenced May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems some OGR drivers does not report extension via metadata, in
such case we extract it from selected filter string