Do not use shared connections from column type thread #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connections cannot be shared between multiple threads. Fixes http://hub.qgis.org/issues/13141
|
I think the whole "shared connections" mechanism should be deprecated in favour of a proper connection pool, which is also already present (QgsPostgresConnPool) and used by some classes (QgsPGConnectionItem and QgsPostgresFeatureIterator) -- was there any plan to switch over or previous discussion about it ? |
|
Locally I have another implementation which does make use of the pool (feels better, imho) |
|
Pushed the pool-based approach |
|
Continues in #2690 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections cannot be shared between multiple threads.
Fixes http://hub.qgis.org/issues/13141