Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Processing] Add GRASS7 r.reclass inline rules (implements Redmine #5583) #2782

Merged
merged 2 commits into from Mar 2, 2016
Merged

[Processing] Add GRASS7 r.reclass inline rules (implements Redmine #5583) #2782

merged 2 commits into from Mar 2, 2016

Conversation

ghost
Copy link

@ghost ghost commented Feb 11, 2016

With this PR, you can write reclass rules in the Processing dialog box (as required in feature request #5583):
qgis_stretch

This will be for QGIS 2.16 because it is a new feature.

Thanks to @volaya, @alexbruy for reviewing...

@gioman
Copy link
Contributor

gioman commented Feb 11, 2016

@medspx many thanks for this, a very important improvement.

@ghost
Copy link
Author

ghost commented Feb 11, 2016

Oops, I didn't take time to make tests under MS-Windows and there is a problem with CR characters (with the MS-Windows shell).
I have to find a workaround before a merge...

@ghost
Copy link
Author

ghost commented Feb 13, 2016

Well, I've found the workaround: create a temp file with reclass rules and use it as input for r.reclass command. Tested on GNU/Linux and MS-Windows.

@gioman
Copy link
Contributor

gioman commented Feb 14, 2016

I really think that regardless of being a new tool (so a new feature) we should commit this and have this very important improvement directly into 2.16. After all I don't see how this Processing improvements can be harmful. The same applies to #2781 and #2788 and #2772 and #2747 and #2787 @volaya @alexbruy @jef-n

alexbruy added a commit that referenced this pull request Mar 2, 2016
[processing] add GRASS7 r.reclass inline rules (fix #5583)
@alexbruy alexbruy merged commit 0061dcc into qgis:master Mar 2, 2016
@ghost ghost deleted the processing_r_reclass branch December 18, 2016 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants