Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quote fields in size/width assistant #2795

Closed
wants to merge 3 commits into from
Closed

Conversation

vmora
Copy link
Contributor

@vmora vmora commented Feb 16, 2016

fix #14257

@nyalldawson
Copy link
Collaborator

LGTM!

@vmora
Copy link
Contributor Author

vmora commented Feb 17, 2016

@nyalldawson the intent test works on my machine... any clue ? (I do compile with astyle option)

@nyalldawson
Copy link
Collaborator

Not sure why the test is passing locally, but I have a hunch it's only written for use on Travis. But the commit does have indentation issues - eg spacing around the brackets is wrong. So it's a valid failure ;)

@vmora
Copy link
Contributor Author

vmora commented Feb 17, 2016

Yes, you're right, fixed, hoping travis will give me the go.

@vmora
Copy link
Contributor Author

vmora commented Feb 17, 2016

because of a trailing white-space and a test that continues to pass on my machine...

@SebDieBln
Copy link
Contributor

@vmora Did you run scripts/prepare-commit.sh?
How about rebasing and squashing those indentation fix commits? Looks much nicer in the history then 😄

@m-kuhn
Copy link
Member

m-kuhn commented Feb 23, 2016

I think this is a very common requirement. What do you think about adding a new QString QgsExpressionFieldWidget::asExpression() method?

@nyalldawson
Copy link
Collaborator

Thanks @vmora - I've manually pushed a version of this as d11e667 which incorporates @m-kuhn's suggestion so we don't miss 2.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants