[Bugfix] no zoom when panning with the keyboard (fixes #14243) #2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good to me, but it'd be much much better if the change came with an automated test reproducing the user interaction. @SebDieBln could you try adding a test in tests/src/core/testqgsmaprotation.cpp and add a test there ? |
strk
added
the
Requires Tests!
|
Beside tests, the change was pushed as commit 138be4a (tested manually, good stuff) |
Yes, I will add a test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the keyboard to do panning on a rotated canvas the canvas was also zoomed out (see Redmine #14243).