Don't require Python 3 for Qt5. #2906
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use separate ENABLE_PYTHON3 option for Python 3.
|
Nice! Can we make this default on for Qt5? |
|
If the general situation is that Qt5 is only supported with Python 3, it makes sense to enable Python 3 along with Qt5, but we should not equate Qt5 with Python 3. |
|
QGIS 3.0 will be Qt5 and Python3 and the two have in common that they render plugins useless - or require updates which no plugins have done yet. Except the situation of python2 + pyqt4-qt5 which I'm not sure if it's shipped anywhere. I therefore assume that in the majority of cases both options will be used in sync. But I agree that this behavior should not be enforced, so your PR is very welcome. |
|
This branch was deleted by mistake, reopening the PR. |
m-kuhn
added
the
Requires Changes!
Fixes qgis_customwidgets,py installation. See also: https://lists.debian.org/debian-gis/2016/03/msg00020.html
|
Manually merged in 81c5f25 Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use separate ENABLE_PYTHON3 option for Python 3.
2.14.0 with 264527a failed to build with Python 3 due to an issue with PyUnicode_AsUTF8String from PyQt5. The bindings build successfully with Python 2 and PyQt5.