Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QgsGeometryUtils::segmentizeArc(): fix full circle segmentization (fixes #29895) #30010

Closed
wants to merge 1 commit into from

Conversation

@rouault
Copy link
Contributor

commented May 29, 2019

This fix display of full circles coming from PostGIS.

@rouault rouault force-pushed the rouault:fix_29895 branch 2 times, most recently from ad23bde to 0d104b6 May 29, 2019

rouault added a commit to rouault/Quantum-GIS that referenced this pull request May 29, 2019
Fix GeoJSON output of MultiPolygon/MultiSurface
There was a lack of a JSon array around rings of a polygon.
This issue is not present in 3.4

Also fixes an issue with gcc 5.5 of Ubuntu 16.04 that doesn't behave
properly with C++11 brace syntax with code from nlohmann/json.hpp.
The code compiles but the result is invalid: `json foo{ json::array{} }`
is serialized as [[]] instead of []. So use old-style constructor
instead: `json foo( json::array() )`

This PR is on top of qgis#30010

@rouault rouault force-pushed the rouault:fix_29895 branch from 0d104b6 to fca15f3 May 29, 2019

rouault added a commit to rouault/Quantum-GIS that referenced this pull request May 29, 2019
Fix GeoJSON output of MultiPolygon/MultiSurface
There was a lack of a JSon array around rings of a polygon.
This issue is not present in 3.4

Also fixes an issue with gcc 5.5 of Ubuntu 16.04 that doesn't behave
properly with C++11 brace syntax with code from nlohmann/json.hpp.
The code compiles but the result is invalid: `json foo{ json::array{} }`
is serialized as [[]] instead of []. So use old-style constructor
instead: `json foo( json::array() )`

This PR is on top of qgis#30010
rouault added a commit to rouault/Quantum-GIS that referenced this pull request May 29, 2019
Fix GeoJSON output of MultiPolygon/MultiSurface
There was a lack of a JSon array around rings of a polygon.
This issue is not present in 3.4

Also fixes an issue with gcc 5.5 of Ubuntu 16.04 that doesn't behave
properly with C++11 brace syntax with code from nlohmann/json.hpp.
The code compiles but the result is invalid: `json foo{ json::array{} }`
is serialized as [[]] instead of []. So use old-style constructor
instead: `json foo( json::array() )`

This PR is on top of qgis#30010
QgsGeometryUtils::segmentizeArc(): fix full circle segmentization (fixes
 #29895)

This fix display of full circles coming from PostGIS.

@rouault rouault force-pushed the rouault:fix_29895 branch from fca15f3 to c4c4836 May 29, 2019

rouault added a commit to rouault/Quantum-GIS that referenced this pull request May 29, 2019
Fix GeoJSON output of MultiPolygon/MultiSurface
There was a lack of a JSon array around rings of a polygon.
This issue is not present in 3.4

Also fixes an issue with gcc 5.5 of Ubuntu 16.04 that doesn't behave
properly with C++11 brace syntax with code from nlohmann/json.hpp.
The code compiles but the result is invalid: `json foo{ json::array{} }`
is serialized as [[]] instead of []. So use old-style constructor
instead: `json foo( json::array() )`

This PR is on top of qgis#30010
nyalldawson added a commit that referenced this pull request May 30, 2019
Fix GeoJSON output of MultiPolygon/MultiSurface
There was a lack of a JSon array around rings of a polygon.
This issue is not present in 3.4

Also fixes an issue with gcc 5.5 of Ubuntu 16.04 that doesn't behave
properly with C++11 brace syntax with code from nlohmann/json.hpp.
The code compiles but the result is invalid: `json foo{ json::array{} }`
is serialized as [[]] instead of []. So use old-style constructor
instead: `json foo( json::array() )`

This PR is on top of #30010
@rouault

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

Was included in #30012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.