QgsGeometryUtils::segmentizeArc(): fix full circle segmentization (fixes #29895) #30010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
added
backport release-3_4
Bug
rouault
force-pushed
the
fix_29895
branch
2 times, most recently
from
ad23bde
to
0d104b6
Compare
qgis#29895) This fix display of full circles coming from PostGIS.
rouault
added a commit
to rouault/QGIS
that referenced
this pull request
May 29, 2019
There was a lack of a JSon array around rings of a polygon.
This issue is not present in 3.4
Also fixes an issue with gcc 5.5 of Ubuntu 16.04 that doesn't behave
properly with C++11 brace syntax with code from nlohmann/json.hpp.
The code compiles but the result is invalid: `json foo{ json::array{} }`
is serialized as [[]] instead of []. So use old-style constructor
instead: `json foo( json::array() )`
This PR is on top of qgis#30010
nyalldawson
pushed a commit
that referenced
this pull request
May 30, 2019
There was a lack of a JSon array around rings of a polygon.
This issue is not present in 3.4
Also fixes an issue with gcc 5.5 of Ubuntu 16.04 that doesn't behave
properly with C++11 brace syntax with code from nlohmann/json.hpp.
The code compiles but the result is invalid: `json foo{ json::array{} }`
is serialized as [[]] instead of []. So use old-style constructor
instead: `json foo( json::array() )`
This PR is on top of #30010
|
Was included in #30012 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix display of full circles coming from PostGIS.