fix #30028 Closing Vertex Edititor crashes the app #30030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterPetrik
added
backport release-3_4
Bug
wonder-sk
approved these changes
May 30, 2019
src/app/vertextool/qgsvertextool.cpp
Outdated
| @@ -313,6 +313,8 @@ QgsVertexTool::~QgsVertexTool() | |||
| delete mVertexBand; | |||
| delete mEdgeBand; | |||
| delete mEndpointMarker; | |||
| if ( mVertexEditor ) | |||
| delete mVertexEditor; | |||
There was a problem hiding this comment.
no need to do "if (x) delete x;" - just do "delete x;"
and we probably don't need to do that anyway since the vertex editor widget has a parent (which will take care of its deletion)
src/app/vertextool/qgsvertextool.cpp
Outdated
| // do not delete immediately because vertex editor | ||
| // can be still used in the qt event loop | ||
| mVertexEditor->deleteLater(); | ||
| mVertexEditor = nullptr; |
There was a problem hiding this comment.
it's not necessary to do mVertexEditor = nullptr; if we are using QPointer (it would be needed if we used raw pointer)
PeterPetrik
force-pushed
the
fix_30028_vertex_editor_crash
branch
from
1da67c0
to
c68ca6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #30028
double delete of mVertexEditor (
unique_ptrin context of Qt's events)