Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix histogram bindings #30033

Merged
merged 2 commits into from Jun 3, 2019

Conversation

@elpaso
Copy link
Contributor

commented May 30, 2019

Hopefully fixes #29700

Fix histogram bindings
Hopfully fixes #29700
@@ -378,8 +378,8 @@ class CORE_EXPORT QgsRasterInterface
maximum = PyFloat_AsDouble( a3 );
}

QgsRasterHistogram h = sipCpp->histogram( a0, a1, minimum, maximum, *a4, a5, a6, a7 );
sipRes = &h;
QgsRasterHistogram *h = new QgsRasterHistogram( sipCpp->histogram( a0, a1, minimum, maximum, *a4, a5, a6, a7 ) );

This comment has been minimized.

Copy link
@nyalldawson

nyalldawson May 30, 2019

Contributor

Doesn't this need wrapping in "sipConvertFromType" ?

This comment has been minimized.

Copy link
@elpaso

elpaso May 31, 2019

Author Contributor

@nyalldawson please have a look to my last commit.

@nyalldawson

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

Is it worth adding a python test for this method? Is there an existing one? Gut feeling is that there's likely NO tests for this method, it predates the focus on stability.

@elpaso elpaso merged commit 1fcc982 into qgis:release-3_4 Jun 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@elpaso

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

Is it worth adding a python test for this method? Is there an existing one? Gut feeling is that there's likely NO tests for this method, it predates the focus on stability.

I'll see what I can do.

elpaso added a commit to elpaso/QGIS that referenced this pull request Jun 9, 2019
Forward port of histogram binding fix with a bonus test
Fwd port of PR qgis#30033
Fixes qgis#29700

With a new test for the bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.