Fix histogram bindings #30033
Merged
Fix histogram bindings #30033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopfully fixes qgis#29700
elpaso
added
Bug
nyalldawson
reviewed
May 30, 2019
| @@ -378,8 +378,8 @@ class CORE_EXPORT QgsRasterInterface | |||
| maximum = PyFloat_AsDouble( a3 ); | |||
| } | |||
|
|
|||
| QgsRasterHistogram h = sipCpp->histogram( a0, a1, minimum, maximum, *a4, a5, a6, a7 ); | |||
| sipRes = &h; | |||
| QgsRasterHistogram *h = new QgsRasterHistogram( sipCpp->histogram( a0, a1, minimum, maximum, *a4, a5, a6, a7 ) ); | |||
There was a problem hiding this comment.
Doesn't this need wrapping in "sipConvertFromType" ?
There was a problem hiding this comment.
@nyalldawson please have a look to my last commit.
nyalldawson
approved these changes
Jun 3, 2019
|
Is it worth adding a python test for this method? Is there an existing one? Gut feeling is that there's likely NO tests for this method, it predates the focus on stability. |
I'll see what I can do. |
elpaso
added a commit
to elpaso/QGIS
that referenced
this pull request
Jun 9, 2019
Fwd port of PR qgis#30033 Fixes qgis#29700 With a new test for the bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #29700