Fix json hanlding of bools and complete json(b) PG support #30137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes qgis#30131 and add tests for jsonutils
elpaso
added
the
Bug
|
Looks good |
|
@m-kuhn thanks for the review! |
m-kuhn
reviewed
Jun 9, 2019
Co-Authored-By: Matthias Kuhn <matthias@opengis.ch>
nyalldawson
reviewed
Jun 9, 2019
| @@ -1057,6 +1059,16 @@ QString QgsPostgresConn::quotedValue( const QVariant &value ) | |||
| } | |||
| } | |||
|
|
|||
| QString QgsPostgresConn::quotedJsonValue( const QVariant &value ) | |||
| { | |||
| if ( value.isNull() || !value.isValid() ) | |||
There was a problem hiding this comment.
Suggested change
| if ( value.isNull() || !value.isValid() ) | |
| if ( value.isNull() || !value.isValid() || value.type() == QVariant::Bool ) | |
| return QgsPostgresConn::quotedValue( value ); |
(for consistency)?
There was a problem hiding this comment.
I've added a few more tests, null, true and false should be handled correctly now.
m-kuhn
reviewed
Jun 10, 2019
Co-Authored-By: Matthias Kuhn <matthias@opengis.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30131 and add tests for jsonutils