[processing] Port "Points along geometry" to QgsFeatureBasedAlgorithm #30175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(and c++), allow distance/start/end offset to be dynamic, avoid algorithm "hangs" when inappropriately small (or 0) distances are used
nyalldawson
added
the
Processing
|
@nyalldawson , are you aiming at 3.8 here? We've pretty much consistently viewed c++ port as stability fix during freeze period. |
|
@nirvn it was deliberately omitted because I don't know 😛 Someone else can make this call. But there definitely is a number of bug fixes included here, the only questionable part is the swap to dynamic parameters (which i consider a prerequisite for any algorithm ported to c++) |
|
On the basis of your description highlighting several fixes, and the inerrant stability improvements of porting to C++, let me make that decision for you: 3.8 it is! :) |
This was referenced Jan 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(and c++), allow distance/start/end offset to be dynamic, avoid algorithm "hangs" when inappropriately small (or 0) distances are used
Refs https://lists.osgeo.org/pipermail/qgis-user/2019-June/043278.html