Only require QTWEBKIT for Qt4 when WITH_QTWEBKIT is true. #3089
Conversation
|
Merged in e888753 |
|
nuking my branch that has been waiting for the above transition to actually happen since january. |
|
What did that branch do? |
|
the above + limiting libqtwebkit-dev to were it will be still available, changing references to QWebView to QgsWebView |
|
Do you mind merging the extra logic you mentioned? |
|
Why? Webkit is still there. |
|
Ok, just hold back with the 💣 |
|
It may be that the Qt maintainers will wait for the blocking issues to be fixed before uploading the qt4 packages without WebKit, if those don't get fixed before the freeze WebKit support in Qt4 may stay, but that seems highly unlikely as Qt4 is EOL making security support for the WebKit module problematic. For the time being WebKit support is still available in the qt4 packages, but it will go away sooner or later. I wouldn't wait with merging changes to support building QGIS without WebKit support in Qt4 until it is actually removed, but there is also a good argument to stick to the current setup until it breaks. |
|
@m-kuhn they already do for long ;) |
|
@sebastic to me this is backwards. If something breaks I'll fix it. It's easier to fix something that is broken, than to anticipate a change and "fix" it beforehand. So I don't know why this is held back forever. |
|
It was held back forever because QGIS isn't ready for the switch to Qt5, see: Debian Bug #784513. python-qt4 without WebKit support has been uploaded to Debian unstable today. |
These changes are required to build QGIS 2.14 with Qt4 but without QtWebKit support, because WebKit support in Qt4 is pending removal as reported in Debian Bug #784514, WebKit support in python-qt4 is pending removal too.