[needs-docs] Drop setting to control label solution method from project labeling settings #30960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just for historical reference these algos come from the original PAL library. Some papers about POPMUSIC and the others can be found here: http://pal.heig-vd.ch/index.php?page=support |
wonder-sk
approved these changes
Jul 29, 2019
m-kuhn
reviewed
Jul 29, 2019
|
Good move |
from project labeling settings This is an unnecessary setting, resulting in 1000's of extra, very complex and untested lines of code. Furthermore, the differences are almost non-existant and it's extremely unlikely end users would (or should) need to change this setting.
nyalldawson
force-pushed
the
drop_label_methods
branch
from
ffaf11a
to
a9cf474
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an unnecessary setting, resulting in 1000's of extra, very complex
and untested lines of code. Furthermore, the differences are almost non-existant
and it's extremely unlikely end users would (or should) need to change this
setting.