Backport 3.8: Fix multi-selection on value relation widget using string fields #31189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code mostly taken from this integration in the postgresprovider / postgresconn x
…ctions we use there and possibly in future there are more coming and renamed the methods fixed indents and comments
…sString" function without JSON
…Variant::List - since these values are not stored as string, the tests don't need to check the GDAL version (what shouldn't have been done before anyway because it only concerns geopackages, where this version is checked on storing data...)
|
Thanks @m-kuhn |
m-kuhn
commented
Aug 12, 2019
| qDebug() << QString::fromStdString( ex.what() ); | ||
| catch ( json::parse_error &ex ) | ||
| { | ||
| qDebug() << QString::fromStdString( ex.what() ); |
There was a problem hiding this comment.
@signedav is this something that can happen in real life? In this case wouldn't a message log entry be better?
There was a problem hiding this comment.
Rarely but still possible. In the case that someone used json in string fields to fill up the valuerelation, what would be technically possible since 3.8 - and if this json strings are not formatted correctly.
I'm okay with log as well...
There was a problem hiding this comment.
Can you do a PR for this on master and we can backport it on top of this one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #30610