Revived globe, compatible with OsgEarth 2.7 #3126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be good to remove all the osg sip files, the work is unfinished and would better fit into the scope of osg (or osgEarth) packages instead. |
| @@ -194,7 +194,7 @@ bool QgsRectangle::contains( const QgsPoint &p ) const | |||
| ymin <= p.y() && p.y() <= ymax; | |||
| } | |||
|
|
|||
| void QgsRectangle::combineExtentWith( QgsRectangle * rect ) | |||
| void QgsRectangle::combineExtentWith( const QgsRectangle * rect ) | |||
There was a problem hiding this comment.
I think this should take a const reference instead of a pointer.
There was a problem hiding this comment.
Better yes, but is it allowed to alter the API like that?
There was a problem hiding this comment.
It's ok - it doesn't break the python API, which is all the freeze applies to
…ectangle::combineExtentWith(const QgsRectangle&)
This was referenced May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reworks the globe plugin for OsgEarth 2.7 compatibility. Various aspects of the plugin have been redesigned, among which layer management, the qgis tile source logic and the settings dialog.