Server: catch Python exceptions from plugins #31299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rldhont @pblottiere @dmarteau I know we should make some housekeeping on the exception hierarchy/handling, but for now this seems a decent solution in order to catch Python errors coming from the plugin's code. |
elpaso
force-pushed
the
server-python-catch-plugins-exceptions
branch
from
65bbd3d
to
f090919
Compare
Make sure Python exceptions are converted into QgsServerException and catched by the main service executor. Without this patch, the server process is terminated (aborted).
elpaso
force-pushed
the
server-python-catch-plugins-exceptions
branch
from
f090919
to
4cc7a0f
Compare
pblottiere
reviewed
Aug 19, 2019
| * Returns the list of content types this handler can serve, default to JSON and HTML. | ||
| * In case a specialized type (such as GEOJSON) is supported, | ||
| * the generic type (such as JSON) should not be listed. | ||
| * \note not available in Python bindings |
Good move 👍. Tanks @elpaso! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure Python exceptions are converted into
QgsServerException and catched by the main
service executor.