-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Server] Extend the WMS FILTER whitelist with IS, NOT, NULL #31517
Conversation
The QGIS Server Filter parameter accept OGC Filter and an SQL where clause. In the case of the SQL where clause, to avoid injection and garanty some safety, QGIS Server uses a whitelist of allowed characters and keywords. The whitelist was AND,OR,IN,=,<,>=,>,>=,!=,',',(,),DMETAPHONE,SOUNDEX. We need to be able to handle NULL values.
cec3652
to
2c21978
Compare
If memory serves me right, I think that this PR fixes an issue raised by @elemoine some weeks ago, but I didn't succeed in retrieving the dedicated ticket... |
Indeed. And the change looks good to me. |
+1 for merge and backport |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport release-3_4
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick 2c2197867c4901c5353cb262b3b54ac155991f7c
# Create a new branch with these backported commits.
git checkout -b backport-31517-to-release-3_4
# Push it to GitHub.
git push --set-upstream origin backport-31517-to-release-3_4
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport Then, create a pull request where the |
The QGIS Server Filter parameter accept OGC Filter and an SQL where clause.
In the case of the SQL where clause, to avoid injection and garanty some safety, QGIS Server uses a whitelist of allowed characters and keywords.
The whitelist was AND,OR,IN,=,<,>=,>,>=,!=,',',(,),DMETAPHONE,SOUNDEX.
We need to be able to handle NULL values.
Description
Checklist
Fixes #11111
at the bottom of the commit messagescripts/prepare-commit.sh
script before each commit