[delimiter text] Add Point{Z,M,ZM} geometry support (fixes #25645) #31595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirvn
added
Data Provider
3nids
approved these changes
Sep 6, 2019
|
@3nids , thanks for the quick review, that'll be my last feature pushed prior to freeze :) |
m-kuhn
reviewed
Sep 6, 2019
| isNull = false; | ||
| QgsPointXY pt; | ||
| bool ok = QgsDelimitedTextProvider::pointFromXY( sX, sY, pt, mSource->mDecimalPoint, mSource->mXyDms ); | ||
| QgsPoint *pt = new QgsPoint(); |
There was a problem hiding this comment.
Suggested change
| QgsPoint *pt = new QgsPoint(); | |
| std::unique_ptr<QgsPoint> pt = qgis::make_unique<QgsPoint>(); |
for good practice and so on ;)
|
I'm tempted to almost call it a fix |
m-kuhn
approved these changes
Sep 6, 2019
|
@m-kuhn , cheers, I'll follow up tomorrow when I get to my workstation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements Point{Z,M,ZM} geometry support to our delimiter text provider.
Checklist
Fixes #11111at the bottom of the commit messagescripts/prepare-commit.shscript before each commit